https://github.com/DeinAlptraum commented:
Thanks for this change! Looks good to me, aside from a few minor comments, most importantly a release note. Generally: for PR titles, a prefix ala "[libclang/python]" woud be good to denote the component or area of the code base, and empty descriptions are discouraged. Use these to add a few more details, as this is what will end up in the `git log` later. On a side note, I see that there are not currently any tests for a failing `reparse` call. If you'd like to add some, that would be great, but not strictly necessary in the scope of this PR. https://github.com/llvm/llvm-project/pull/102410 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
