EricWF added inline comments.
================ Comment at: CMakeLists.txt:43 +if (WIN32 AND NOT MINGW) + set(LIBCXX_TARGETING_WINDOWS ON) +else() ---------------- smeenai wrote: > Not the biggest fan of this name, since it's not obvious why MinGW shouldn't > count as targeting Windows. I thought of `LIBCXX_TARGETING_NATIVE_WINDOWS` or > `LIBCXX_TARGETING_MSVCRT` instead, but MinGW is also native Windows and > targets MSVCRT, so those names aren't any better from that perspective > either. I can't think of anything else at the moment, but I'm sure there's a > better name. Thanks for the feedback. I'm not exactly sure how this macro should be defined either. I thought that `MinGW` provided its own C library runtime wrappers that forward to `MSVCRT`. The difference I was imagining between Native Windows builds and `MinGW` is that it's possible to use `pthread` with `MinGW` but not with native Windows targets. https://reviews.llvm.org/D28441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
