AaronBallman wrote: > > This sounds more like an unrelated refactoring change. I'm going to hold > > off on doing that in this patch. > > With this change, some of modified functions get multiple boolean back to > > back and we are for some of them at 11+ parameters. I think some cleanup > > would be in order > > WDYT @AaronBallman ?
Yeah, this did increase our tech debt slightly, so I think a cleanup is definitely needed around here. Given that this patch already landed, I'm fine with it being done as a follow-up, but I'd like that follow-up to happen sooner rather than later so we don't leave the cleanup for the next person to come along and deal with. In the future, I think it would be better to do the cleanup as an NFC change when a reviewer asks for it, then land additional changes on top of the cleaned up code (obviously this is also situational and there may be times when other approaches make more sense). https://github.com/llvm/llvm-project/pull/100392 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
