https://github.com/DeinAlptraum commented:

I agree with what Endill said: this is a rather big change and I'm not sure I 
see it adding enough value to justify this.
It also adds quite some complexity on top of the otherwise relatively 
light-weight Python bindings. I generally like seeing changes towards better 
typing annotations, but this is not something we need to push through 
no-matter-what and e.g. the `type: ignore`s are "good enough" for our case.

Another reason I'm hesitant to support this, is that the bindings currently 
depend only on the Python standard library, and adding e.g. `ctyped` would 
break this. Adding outside dependencies is not _strictly_ a problem, but again 
any change to this would imo need a good justification that I don't see at the 
moment.

https://github.com/llvm/llvm-project/pull/101941
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to