ldionne wrote:

> @ldionne I'm starting to think that we should have a generic module in 
> https://github.com/llvm/llvm-project/tree/main/cmake/Modules that would be 
> controlled by `LLVM_USE_LIBC` and define `libc-headers`, `libc-static` and 
> `libc-shared`. That way we could avoid duplicating this logic in every 
> subproject. What do you think?

I agree, but I might put it in `runtimes/cmake/Modules` where we already have 
some stuff. I also wonder if we want to use  `LLVM_USE_LIBC` or 
`RUNTIMES_USE_LIBC` or something else. Historically, `LLVM_FOO` settings are 
mostly things that we've inherited from `<monorepo>/llvm/CMakeLists.txt` and 
tried to move away from.

https://github.com/llvm/llvm-project/pull/101688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to