================ @@ -0,0 +1,99 @@ +// RUN: %clang_cc1 -emit-llvm %s -triple x86_64-unknown-linux-gnu -o - | FileCheck %s ---------------- darkbuck wrote:
> Please don't merge an "auto-generated" file that isn't actually autogenerated > by the in-tree version. > > (Is --check-attributes not what you want?) yeah, `--check-attributes` only enable function attributes output per function. There's no still no attr definition output. I have to make the following change: ``` $ git diff diff --git a/llvm/utils/UpdateTestChecks/common.py b/llvm/utils/UpdateTestChecks/common.py index eb212ed304e9..2161a3589966 100644 --- a/llvm/utils/UpdateTestChecks/common.py +++ b/llvm/utils/UpdateTestChecks/common.py @@ -2156,10 +2156,6 @@ def filter_globals_according_to_preference( return global_val_lines_w_index assert global_check_setting == "smart" - if nameless_value.check_key == "#": - # attribute sets are usually better checked by --check-attributes - return [] - def extract(line, nv): p = ( "^" ``` Shall I use the original test check? We need to check attribute definitions including 'convergent'. https://github.com/llvm/llvm-project/pull/100637 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits