MaskRay wrote:

> Aren't hashes supposed to be deterministic ?
> 
> Can we add a override for builds with asserts turned ON to favor determinism ?
> 
> Could have an API to set the determinism flag ?
> 
> This also has an effect on Build ID computation ?

Some hashes are supposed to be deterministic, but `Hashing.h` isn't .
The file-level documentation  and `get_execution_seed` are very clear about the 
unstability.

If you want to deploy assertions builds and have concern about 
non-deterministism, set LLVM_ABI_BREAKING_CHECKS to `FORCE_OFF`.

The unstable property is important to ensure that no test relies on the 
particular implementation and allow us to replace the implementation, which 
would be infeasible if people keep adding brittle tests.

https://github.com/llvm/llvm-project/pull/96282
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to