davidtrevelyan wrote:

> Can we split into 3 patches?
> 
> 1. LLVM
> 2. Clang
> 3. Compiler-rt
> 
> And each patch should have tests

Thanks for the suggestion @vitalybuka - after some thought, we think we can 
remove the llvm changes entirely now, and so here's our plan:

1. close this PR soon (giving a little time for any interested parties to give 
feedback),
2. remove the LLVM changes,
3. open a PR for the Clang changes (using temporary stubs for 
`__rtsan_realtime_enter()` and `__rtsan_realtime_exit()`), and finally
4. follow this with a PR that ties it all end-to-end in compiler-rt.

Hope that all makes sense - please let us know if any alarm bells are ringing 
in your head. We will of course also sweep our patch for any missing test 
coverage. 

Thanks again!

 

https://github.com/llvm/llvm-project/pull/100120
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to