skatrak wrote: > Code changes look good to me. I can't speak to the needs of anyone else using > offloading. > > I see this is copied exactly from `Toolchains/Clang.cpp`. I think that's okay > for such a small bit of code.
Thank you for the quick review. Yes, it's basically copied from clang, just like most of the other code we have in there, hopefully we can at some point refactor things a bit more. This is part of a PR stack, and the last one shows a use case for this: - https://github.com/llvm/llvm-project/pull/100154 - https://github.com/llvm/llvm-project/pull/100155 - https://github.com/llvm/llvm-project/pull/100156 https://github.com/llvm/llvm-project/pull/100152 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
