================
@@ -14266,6 +14277,71 @@ 
CodeGenFunction::EmitAArch64CpuSupports(ArrayRef<StringRef> FeaturesStrs) {
   return Result;
 }
 
+Value *CodeGenFunction::EmitRISCVCpuSupports(ArrayRef<StringRef> FeaturesStrs,
+                                             unsigned &MaxGroupIDUsed) {
+
+  const unsigned FeatureBitSize = llvm::RISCV::RISCVFeatureBitSize;
----------------
preames wrote:

Please ignore my comment here about using weak symbols.  After reflecting 
further, I realized that having a link time dependence on the compiler support 
library is entirely reasonable - so long as that dependence is only present if 
the feature is actually used, as is done here.  

https://github.com/llvm/llvm-project/pull/85786
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to