zeroomega wrote:
Hi,
This test introduced TimeProfilerTest and it is currently breaking on windows.
It looks like related to the path separator. Error message:
```
Script:
--
C:\b\s\w\ir\x\w\llvm_build\tools\clang\unittests\Support\.\ClangSupportTests.exe
--gtest_filter=TimeProfilerTest.TemplateInstantiations
--
C:\b\s\w\ir\x\w\llvm-llvm-project\clang\unittests\Support\TimeProfilerTest.cpp:278
Expected equality of these values:
R"(
Frontend
| ParseFunctionDefinition (fooB)
| ParseFunctionDefinition (fooMTA)
| ParseFunctionDefinition (fooA)
| ParseDeclarationOrFunctionDefinition (test.cc:3:5)
| | ParseFunctionDefinition (user)
| PerformPendingInstantiations
| | InstantiateFunction (fooA<int>, ./a.h:7)
| | | InstantiateFunction (fooB<int>, ./b.h:3)
| | | InstantiateFunction (fooMTA<int>, ./a.h:4)
)"
Which is: "\nFrontend\n| ParseFunctionDefinition (fooB)\n|
ParseFunctionDefinition (fooMTA)\n| ParseFunctionDefinition (fooA)\n|
ParseDeclarationOrFunctionDefinition (test.cc:3:5)\n| | ParseFunctionDefinition
(user)\n| PerformPendingInstantiations\n| | InstantiateFunction (fooA<int>,
./a.h:7)\n| | | InstantiateFunction (fooB<int>, ./b.h:3)\n| | |
InstantiateFunction (fooMTA<int>, ./a.h:4)\n"
buildTraceGraph(Json)
Which is: "\nFrontend\n| ParseFunctionDefinition (fooB)\n|
ParseFunctionDefinition (fooMTA)\n| ParseFunctionDefinition (fooA)\n|
ParseDeclarationOrFunctionDefinition (test.cc:3:5)\n| | ParseFunctionDefinition
(user)\n| PerformPendingInstantiations\n| | InstantiateFunction (fooA<int>,
.\\a.h:7)\n| | | InstantiateFunction (fooB<int>, .\\b.h:3)\n| | |
InstantiateFunction (fooMTA<int>, .\\a.h:4)\n"
With diff:
@@ -7,5 +7,5 @@
| | ParseFunctionDefinition (user)
| PerformPendingInstantiations
-| | InstantiateFunction (fooA<int>, ./a.h:7)
-| | | InstantiateFunction (fooB<int>, ./b.h:3)
-| | | InstantiateFunction (fooMTA<int>, ./a.h:4)\n
+| | InstantiateFunction (fooA<int>, .\\a.h:7)
+| | | InstantiateFunction (fooB<int>, .\\b.h:3)
+| | | InstantiateFunction (fooMTA<int>, .\\a.h:4)\n
```
Could you revert your change and fix it please?
https://github.com/llvm/llvm-project/pull/98320
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
