llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Rafael Stahl (rafzi) <details> <summary>Changes</summary> `T` is expected to be a pointer type. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-nullptr --- Full diff: https://github.com/llvm/llvm-project/pull/99472.diff 2 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst (+1-1) - (modified) clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp (+2-2) ``````````diff diff --git a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst index 5783280478dc1..57c4829431e76 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst @@ -35,7 +35,7 @@ Examples: int* x; std::unique_ptr<int> x; std::shared_ptr<int> x; - gsl::not_null<int> x; + gsl::not_null<int*> x; }; // Bad, rvalue reference member diff --git a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp index 5a5d05bb4e94e..e3864be134da3 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp @@ -18,7 +18,7 @@ struct Ok { const int *pc; std::unique_ptr<int> up; std::shared_ptr<int> sp; - gsl::not_null<int> n; + gsl::not_null<int*> n; }; struct ConstMember { @@ -60,7 +60,7 @@ struct Ok2 { const Foo *pc; std::unique_ptr<Foo> up; std::shared_ptr<Foo> sp; - gsl::not_null<Foo> n; + gsl::not_null<Foo*> n; }; struct ConstMember2 { `````````` </details> https://github.com/llvm/llvm-project/pull/99472 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
