pskrgag wrote: Thank you for review!
I've applied your suggestions and fixed test failures. Messed up a bit with shadowing in constructor. > Usually, GitHub PRs prefer "merges" over "force-pushes". Whenever you > force-push, all the inline remarks could get lost, as it fails to track the > lines where the comments were made Oh, ok. I've never really worked with gh workflow, so didn't know that. Thank you for guidance! https://github.com/llvm/llvm-project/pull/98941 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
