https://github.com/steakhal requested changes to this pull request.

Looks pretty good. Thanks for working on the issue.
I didn't see any major blocking issue with the PR, so good job on that!

Overall, be sure to follow the llvm [coding 
style](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly),
 including using upper case variable names.

Thanks again for working on this :)

https://github.com/llvm/llvm-project/pull/98941
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to