ChuanqiXu9 wrote: Haven't look into the details but just a quick scanning.
I feel the name `[[coro_inplace_task]]` is not so good. Since it doesn't happen unconditionally. It happens conditionally. I still want to try to make it clear in the name. I still like names like `[[coro_elide_after_await]]`, which I feel is more clear. Another point is, I feel the summary may be hard for other people or future contributors to understand. I feel it may be better to split it to 3 parts: one for C++'s end users (or you can skip this part in the summary since this should be present in Attr.doc), a high level introduction to clang's developers for what this PR is for, then an explanation what this patch did in low level for reviewers of the patch. (So the reviewers don't need to dig this out by themselves.) https://github.com/llvm/llvm-project/pull/98971 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
