compnerd marked an inline comment as done. compnerd added inline comments.
================ Comment at: src/typeinfo.cpp:28-32 + static constexpr const size_t fnv_offset_basis = 14695981039346656037; + static constexpr const size_t fnv_prime = 10995116282110; +#else + static constexpr const size_t fnv_offset_basis = 2166136261; + static constexpr const size_t fnv_prime = 16777619; ---------------- majnemer wrote: > majnemer wrote: > > Why make these static? Seems strange to use that storage duration. > These literals are ill-formed, I think you need a ULL suffix here. Oh, just to ensure that they are handled as literal constants. I can drop the static if you like, since the compiler should do the right thing anyways. Repository: rL LLVM https://reviews.llvm.org/D28212 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
