EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
Holy crap those improvements are impressive. This LGTM. I'm assuming @mclow.lists has nothing left to say about this. ================ Comment at: libcxx/include/__string:542 +template <class _CharT, class _Traits> +_LIBCPP_CONSTEXPR_AFTER_CXX11 +const _CharT * ---------------- Please add `inline` to the template so `-fvisibility-inlines-hidden` works with it. https://reviews.llvm.org/D27068 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
