yronglin wrote:

Thanks for your review!

> Can we simplify further by lexing the partition along with the module name, 
> when there is one?

Let me give a try, We may need to move the logic in Parser to Lex stage.

> We could also have a ModuleNameInfo::toString() function we could use in a 
> couple places.

Sure, But it may only be useful for C++20 Modules. Modules in Objective-C and 
other languages ​​need to be separated by '.'.

https://github.com/llvm/llvm-project/pull/90574
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to