malcolm.parsons added a comment.
https://reviews.llvm.org/D28022 changes performance-unnecessary-value-param so
that it handles this part of modernize-pass-by-value.
So this isn't the end of the story here yet.
================
Comment at:
clang-tools-extra/trunk/test/clang-tidy/misc-move-constructor-init.cpp:1
-// RUN: %check_clang_tidy %s misc-move-constructor-init %t -- -- -std=c++11
-isystem %S/Inputs/Headers
+// RUN: %check_clang_tidy %s
misc-move-constructor-init,modernize-pass-by-value %t -- \
+// RUN: -config='{CheckOptions: \
----------------
alexfh wrote:
> Test for one check running a different check is somewhat confusing. If we
> need to ensure that the patterns the two checks target don't overlap, maybe
> we should rename the test (<check1>+<check2>.cpp or something like that)?
Doing it like this was to show that no functionality was lost, not that there's
no overlap.
The pass-by-value tests can be moved somewhere else.
Repository:
rL LLVM
https://reviews.llvm.org/D26453
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
