https://github.com/trcrsired created 
https://github.com/llvm/llvm-project/pull/96856

https://github.com/llvm/llvm-project/issues/96247

These libraries are not linked for windows gnu targets since the libraries are 
not linked. I need to find out what's going on here. But first, I will just run 
CI to see whether anything breaks. I guess the CMakeListst.txt File is just 
wrong by not linking. However, it looks weird it is only an issue on 
windows-gnu target since other targets should have the same issue, right?

>From 8cb9b9d3e97250f1c665c118f32202b3f7aca31a Mon Sep 17 00:00:00 2001
From: cqwrteur <100043421+trcrsi...@users.noreply.github.com>
Date: Thu, 27 Jun 2024 02:10:40 -0400
Subject: [PATCH] Attempt to fix issue 96247

https://github.com/llvm/llvm-project/issues/96247

These libraries are not linked for windows gnu targets since the libraries are 
not linked. I need to find out what's going on here. But first, I will just run 
CI to see whether anything breaks. I guess this CMakeFile is just wrong.
---
 clang-tools-extra/test/CMakeLists.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/clang-tools-extra/test/CMakeLists.txt 
b/clang-tools-extra/test/CMakeLists.txt
index 0953ff2531e1a..763ce8f967852 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -70,6 +70,12 @@ endforeach()
 if (NOT WIN32 OR NOT LLVM_LINK_LLVM_DYLIB)
   llvm_add_library(
       CTTestTidyModule
+      LINK_LIBS
+      clangAST
+      clangASTMatchers
+      clangTooling
+      clangBasic
+      clangTidy
       MODULE clang-tidy/CTTestTidyModule.cpp
       PLUGIN_TOOL clang-tidy)
 endif()

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to