Sirraide wrote:

> Initially I've implemented the target errors through std::string. Then 
> changed to diag::kind after reading InternalsManual. I'm not sure what is 
> better.

Hmm, if they’re not changing very often (if at all), then I’d also use DiagIDs 
for this, yeah.


https://github.com/llvm/llvm-project/pull/96363
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to