On Fri, Dec 16, 2016 at 12:21 AM, Akira Hatanaka <ahatan...@apple.com> wrote:
> > On Dec 15, 2016, at 9:18 PM, Nico Weber <tha...@chromium.org> wrote: > > On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka <ahatan...@apple.com> > wrote: > >> >> On Dec 15, 2016, at 9:08 PM, Nico Weber <tha...@chromium.org> wrote: >> >> I think the problem was that you didn't pipe the output to /dev/null or >> -, and so a .ll file got created which now confuses the bots. >> >> I suggest: >> 1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through >> magic lit vars to find one that expands to the right thing) >> 2. If the intent for this is to be a -verify check, add that back >> 3. If not, remove expected-no-diagnostics >> 4. If not, is this a FileCheck test? If so, pipe output to FileCheck, add >> CHECK lines >> 5. If it isn't FileCheck either, what does this test? >> >> >> I intended to do IRGen because that was where it was crashing. >> > > Then the test should probably be somewhere in test/CodeGenCXX and > FileCheck that the generated IR looks mostly correct :-) > > > > Yes, I think the test should FileCheck the IR. The bugs I fixed are in > Sema, however the crash occurs in IRGen. In that case, should the test go > to CodeGen* or Sema*? I see several tests in SemaTemplate are generating IR > (using -emit-llvm). > Hm, I guess it's fine to keep it here then. (I find this surprising, though.) > > >> On Fri, Dec 16, 2016 at 12:05 AM, Nico Weber <tha...@chromium.org> wrote: >> >>> Are you aware that this is still failing on all the bots? ( >>> http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493 >>> eg) >>> >>> On Thu, Dec 15, 2016 at 11:18 PM, Akira Hatanaka via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>>> Author: ahatanak >>>> Date: Thu Dec 15 22:18:53 2016 >>>> New Revision: 289919 >>>> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=289919&view=rev >>>> Log: >>>> Remove "-disable-llvm-optzns -verify" from the RUN line. >>>> >>>> Modified: >>>> cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp >>>> >>>> Modified: cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp >>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/ >>>> SemaTemplate/default-expr-arguments-3.cpp?rev=289919&r1= >>>> 289918&r2=289919&view=diff >>>> ============================================================ >>>> ================== >>>> --- cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp (original) >>>> +++ cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp Thu Dec >>>> 15 22:18:53 2016 >>>> @@ -1,4 +1,4 @@ >>>> -// RUN: %clang_cc1 -std=c++14 -emit-llvm -disable-llvm-optzns -verify >>>> %s >>>> +// RUN: %clang_cc1 -std=c++14 -emit-llvm -o - %s >>>> // expected-no-diagnostics >>>> >>>> namespace PR28795 { >>>> >>>> >>>> _______________________________________________ >>>> cfe-commits mailing list >>>> cfe-commits@lists.llvm.org >>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >>> >>> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
