rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lib/Serialization/ASTReader.cpp:5870-5876
+    TL.setWrittenTypeSpec(
+        static_cast<DeclSpec::TST>(Reader.getRecordData()[Idx++]));
+    TL.setWrittenSignSpec(
+        static_cast<DeclSpec::TSS>(Reader.getRecordData()[Idx++]));
+    TL.setWrittenWidthSpec(
+        static_cast<DeclSpec::TSW>(Reader.getRecordData()[Idx++]));
+    TL.setModeAttr(Reader.getRecordData()[Idx++]);
----------------
Can you remove the `.getRecordData()` here and use 
`ASTRecordReader::operator[]` instead?


https://reviews.llvm.org/D27784



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D27784: Add a class... Richard Smith via Phabricator via cfe-commits

Reply via email to