https://github.com/mizvekov approved this pull request.

I think what I tried to do here is generally consistent: The convention on the 
Text node dumper is to add a space at the beginning of the field you want to 
append.

I think the true issue here is the label: It breaks convention by adding a 
space after the colon.

I think it would be better to fix that, but I don't know the impact.

Since right now this field is only added after the label, this makes little 
practical difference, so I leave it up to you, either way is fine.

Thanks for the fix!

https://github.com/llvm/llvm-project/pull/95213
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to