================ @@ -318,6 +318,9 @@ namespace { if (Diags.hasUnrecoverableErrorOccurred()) return; + if (RD->shouldEmitInExternalSource()) ---------------- ChuanqiXu9 wrote:
Yes, I think it is not bad to put the check `RD->shouldEmitInExternalSource()` into `HandleVTable`. I feel the most natural logic may be, I see a vtable then I pass it to the consumer and it is the job of the consumer to decide whether or not to emit it. WDYT? https://github.com/llvm/llvm-project/pull/75912 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits