a.sidorin added a comment. Thank you Devin!
================ Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:30 +// +// The gtest unit testing API provides macros for assertions that that expand +// into an if statement that calls a series of constructors and returns ---------------- "that that" ================ Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:105 + void modelAssertionResultBoolConstructor(const CXXConstructorCall *Call, + CheckerContext &C) const; + ---------------- Misalignment here and below ================ Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:182 + + SVal ThisSuccess = getAssertionResultSuccessFieldValue(AssertResultClassDecl, + ThisVal, State); ---------------- Shouldn't we just bind OtherSuccess to our field? https://reviews.llvm.org/D27773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
