================
@@ -199,7 +199,8 @@ class DeclarationFragments {
     return *this;
   }
 
-  DeclarationFragments &replace(std::string NewSpelling, unsigned Position) {
----------------
daniel-grumberg wrote:

I would prefer to keep the value semantics version and instead move assign the 
value, that way callers can move the string in and avoid any copies.

https://github.com/llvm/llvm-project/pull/94820
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to