legrosbuffle wrote:

> Could this also be applied for 
> https://github.com/llvm/llvm-project/issues/69577?

Weirdly, those two checks are using distinct methods to infer whether the 
underlying container is mutated. `unnecessary-copy-initialization` uses 
`doesNotMutateObject` while `performance-unnecessary-value-param` uses 
`FunctionParmMutationAnalyzer`.

So unfortunately this change won't improve 
`performance-unnecessary-value-param`.

I can have a look at unifying both in a subsequent PR.

https://github.com/llvm/llvm-project/pull/94362
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to