smanna12 wrote:

> Why add the check here rather than add an assertion at the point of 
> assignation (i.e.
> 
> ```
> Init = Result.getAs<Expr>();
> ```
> 
> Since Init is passed into CheckSelfReference on line 13712 where it's 
> dereferenced the same issue binds there as well

Thanks @feg208 for reviews! I agree with you. I missed the case you mentioned 
and fixed the patch.

https://github.com/llvm/llvm-project/pull/94368
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to