arphaman added inline comments.
================ Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:133 + VariableLocation.setBegin(tidy::utils::lexer::findLocationAfterToken( + VariableLocation.getEnd(), Tokens, *Result.Context)); + } ---------------- If you use `ArrayRef` in `findLocationAfterToken` then you won't need to create a `std::vector` here as you should be able to pass in a constant array `{tok::semi, tok::comma}` ================ Comment at: clang-tidy/utils/LexerUtils.h:32 +SourceLocation findLocationAfterToken(SourceLocation Loc, + const std::vector<tok::TokenKind> &Tokens, + ASTContext &Context); ---------------- You can use `ArrayRef<tok::TokenKind>` here. https://reviews.llvm.org/D27621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits