efriedma-quic wrote:

I'm skeptical it's correct to skip all the assertions like this; the assertions 
are there to ensure the layout of the LLVM IR type matches the layout provided 
by the RecordLayout.  If the LLVM IR layout is wrong, address-related 
computations will be wrong, and ultimately you'll miscompile.  We don't really 
care whether the RecordLayout is consistent with language rules.

The correct answer here is probably to fix the sizes in the RecordLayout 
itself; in particular, the DataSize of the members.

https://github.com/llvm/llvm-project/pull/93809
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to