dhruvachak wrote: > > There are duplicate definitions of the following > > ``` > > bool llvm::omp::target::ompt::Initialized = false; > > > > ompt_get_callback_t llvm::omp::target::ompt::lookupCallbackByCode = nullptr; > > ompt_function_lookup_t llvm::omp::target::ompt::lookupCallbackByName = > > nullptr; > > ``` > > > > > > > > > > > > > > > > > > > > > > > > in src/OpenMP/OMPT/Callback.cpp and > > plugins-nextgen/common/OMPT/OmptCallback.cpp > > Can you remove the ones in the plugin? Otherwise, it's not clear which > > definition is being used. > > Sure, do you get that upstream? If so, wonder why I didn't get it.
I did not build upstream but looking at downstream, I think for some reason they don't show up as duplicate symbols. But looking at the code, they should be removed. There are uses of those variables in the plugin, so there should be only 1 definition. > > I guess we would just have it to where the `libomptarget` instance handles > all the OMPT. https://github.com/llvm/llvm-project/pull/87009 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
