malcolm.parsons added inline comments.
================
Comment at: clang-tidy/misc/MiscStringCompareCheck.cpp:48
+ Finder->addMatcher(ifStmt(hasCondition(binaryOperator(hasOperatorName("=="),
+ hasLHS(strCompare))))
+ .bind("match"),
----------------
malcolm.parsons wrote:
> Doesn't test RHS.
I mean: doesn't test whether RHS is zero.
https://reviews.llvm.org/D27210
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
