fhahn added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6521
+emitX86DeclareSimdFunction(const FunctionDecl *FD,
+ llvm::APSInt VLENVal,
+ ArrayRef<ParamAttrTy> ParamAttrs,
----------------
Stray space
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6522
+ llvm::APSInt VLENVal,
+ ArrayRef<ParamAttrTy> ParamAttrs,
+ OMPDeclareSimdDeclAttr::BranchStateTy State,
----------------
Stray space
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6615
+static void
+emitAArch64DeclareSimdFunction(CodeGenModule & CGM, const FunctionDecl *FD,
+ const llvm::APSInt &UserVLEN,
----------------
Stray space in & CGM
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6662
+ auto MaskTy = getAArch64MaskTy(Data.ISA,
+ Data.VecRegSize/ VLEN.getExtValue(),
+ VLEN.getExtValue(),
CGM.getLLVMContext());
----------------
Missing space around / in Data.VecRegSize/ VLEN.getExtValue()
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6676
+ Out << 'l';
+ if (!!ParamAttr.StrideOrArg)
+ Out << ParamAttr.StrideOrArg;
----------------
Is the !! intentional?
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6687
+
+ if (!!ParamAttr.Alignment)
+ Out << 'a' << ParamAttr.Alignment;
----------------
Is the !! intentional?
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6739
+ std::vector<std::string> OutVec;
+ std::string MangledName = CGM.getMangledName(GlobalDecl(FD));
for (auto *Attr : FD->specific_attrs<OMPDeclareSimdDeclAttr>()) {
----------------
Two spaces after =
https://reviews.llvm.org/D27250
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
