malcolm.parsons added inline comments.
================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// marked with override or final.
----------------
Do we want to warn about methods in templated classes at all?
================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:284
+template <typename T>
+struct NegativOverrideImpl : public NegativeDependentTypeInterface<T> {
+ void Method(ExpensiveToCopyType E) override {}
----------------
Typo Negativ -> Negative.
Repository:
rL LLVM
https://reviews.llvm.org/D27248
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
