HighCommander4 wrote: > I have a few questions: > > 1. Do we want an RFC in discourse for the changes in `DeclPrinter`?
An RFC might be overkill, but asking for review from a clang code owner for changes to an interface such as `PrintingPolicy` or `PrintingCallbacks` is probably a good idea. (If the clang reviewer feels an RFC is warranted, we can do it then.) > 2. Do you think we should also add some test cases to > `DeclPrinterTest.cpp`? Yep, good call! https://github.com/llvm/llvm-project/pull/89557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
