================
@@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final
Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS,
Instruction *CxtI, bool IsAnd,
bool IsLogical = false);
- Value *matchSelectFromAndOr(Value *A, Value *B, Value *C, Value *D,
+ Value *matchSelectFromAndOr(Value *A, Value *C, Value *B, Value *D,
----------------
Troy-Butler wrote:
The pre-commit version of the function declaration listed the parameters in the
order A, C, B, D to indicate the expected grouping of arguments, i.e. (A & C) |
(B & D). Changing the order to A, B, C, D would have required reworking the
function, which seemed outside the scope of this issue - so I opted to reflect
the A, C, B, D order in the function declaration instead. However, as
requested, I have modified the parameter names, listed them in logically
ascending order, and reworked the function to match.
https://github.com/llvm/llvm-project/pull/89512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
