STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.
Add static_cast<int>. In these cases, the values are guaranteed to be small-ish,
and they're being compared to int elements.
https://reviews.llvm.org/D27023
Files:
test/std/algorithms/alg.modifying.operations/alg.move/move.pass.cpp
test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pass.cpp
test/std/algorithms/alg.nonmodifying/alg.foreach/test.pass.cpp
test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp
test/std/algorithms/alg.sorting/alg.merge/merge_comp.pass.cpp
test/std/containers/sequences/deque/deque.capacity/access.pass.cpp
Index: test/std/containers/sequences/deque/deque.capacity/access.pass.cpp
===================================================================
--- test/std/containers/sequences/deque/deque.capacity/access.pass.cpp
+++ test/std/containers/sequences/deque/deque.capacity/access.pass.cpp
@@ -53,37 +53,37 @@
{
std::deque<int> c = make<std::deque<int> >(10);
for (unsigned i = 0; i < 10; ++i)
- assert(c[i] == i);
+ assert(c[i] == static_cast<int>(i));
for (unsigned i = 0; i < 10; ++i)
- assert(c.at(i) == i);
+ assert(c.at(i) == static_cast<int>(i));
assert(c.front() == 0);
assert(c.back() == 9);
}
{
const std::deque<int> c = make<std::deque<int> >(10);
for (unsigned i = 0; i < 10; ++i)
- assert(c[i] == i);
+ assert(c[i] == static_cast<int>(i));
for (unsigned i = 0; i < 10; ++i)
- assert(c.at(i) == i);
+ assert(c.at(i) == static_cast<int>(i));
assert(c.front() == 0);
assert(c.back() == 9);
}
#if TEST_STD_VER >= 11
{
std::deque<int, min_allocator<int>> c = make<std::deque<int, min_allocator<int>> >(10);
for (unsigned i = 0; i < 10; ++i)
- assert(c[i] == i);
+ assert(c[i] == static_cast<int>(i));
for (unsigned i = 0; i < 10; ++i)
- assert(c.at(i) == i);
+ assert(c.at(i) == static_cast<int>(i));
assert(c.front() == 0);
assert(c.back() == 9);
}
{
const std::deque<int, min_allocator<int>> c = make<std::deque<int, min_allocator<int>> >(10);
for (unsigned i = 0; i < 10; ++i)
- assert(c[i] == i);
+ assert(c[i] == static_cast<int>(i));
for (unsigned i = 0; i < 10; ++i)
- assert(c.at(i) == i);
+ assert(c.at(i) == static_cast<int>(i));
assert(c.front() == 0);
assert(c.back() == 9);
}
Index: test/std/algorithms/alg.sorting/alg.merge/merge_comp.pass.cpp
===================================================================
--- test/std/algorithms/alg.sorting/alg.merge/merge_comp.pass.cpp
+++ test/std/algorithms/alg.sorting/alg.merge/merge_comp.pass.cpp
@@ -46,7 +46,7 @@
OutIter r = std::merge(InIter1(ia), InIter1(ia+N),
InIter2(ib), InIter2(ib+N), OutIter(ic), pred);
assert(base(r) == ic+2*N);
- assert(ic[0] == 2*N-1);
+ assert(ic[0] == static_cast<int>(2*N-1));
assert(ic[2*N-1] == 0);
assert(std::is_sorted(ic, ic+2*N, std::greater<int>()));
assert(pred.count() <= (N + N - 1));
@@ -70,7 +70,7 @@
OutIter r = std::merge(InIter1(ia), InIter1(ia+N),
InIter2(ib), InIter2(ib+N), OutIter(ic), pred);
assert(base(r) == ic+2*N);
- assert(ic[0] == 2*N-1);
+ assert(ic[0] == static_cast<int>(2*N-1));
assert(ic[2*N-1] == 0);
assert(std::is_sorted(ic, ic+2*N, std::greater<int>()));
assert(pred.count() <= (N + N - 1));
Index: test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp
===================================================================
--- test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp
+++ test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp
@@ -40,7 +40,7 @@
InIter2(ib), InIter2(ib+N), OutIter(ic));
assert(base(r) == ic+2*N);
assert(ic[0] == 0);
- assert(ic[2*N-1] == 2*N-1);
+ assert(ic[2*N-1] == static_cast<int>(2*N-1));
assert(std::is_sorted(ic, ic+2*N));
delete [] ic;
delete [] ib;
@@ -62,7 +62,7 @@
InIter2(ib), InIter2(ib+N), OutIter(ic));
assert(base(r) == ic+2*N);
assert(ic[0] == 0);
- assert(ic[2*N-1] == 2*N-1);
+ assert(ic[2*N-1] == static_cast<int>(2*N-1));
assert(std::is_sorted(ic, ic+2*N));
delete [] ic;
delete [] ib;
Index: test/std/algorithms/alg.nonmodifying/alg.foreach/test.pass.cpp
===================================================================
--- test/std/algorithms/alg.nonmodifying/alg.foreach/test.pass.cpp
+++ test/std/algorithms/alg.nonmodifying/alg.foreach/test.pass.cpp
@@ -35,5 +35,5 @@
for_each_test(0));
assert(f.count == s);
for (unsigned i = 0; i < s; ++i)
- assert(ia[i] == i+1);
+ assert(ia[i] == static_cast<int>(i+1));
}
Index: test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pass.cpp
===================================================================
--- test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pass.cpp
+++ test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pass.cpp
@@ -53,7 +53,7 @@
OutIter r = std::move_backward(InIter(ia), InIter(ia+N), OutIter(ib+N));
assert(base(r) == ib);
for (unsigned i = 0; i < N; ++i)
- assert(*ib[i] == i);
+ assert(*ib[i] == static_cast<int>(i));
}
#endif // _LIBCPP_HAS_NO_RVALUE_REFERENCES
Index: test/std/algorithms/alg.modifying.operations/alg.move/move.pass.cpp
===================================================================
--- test/std/algorithms/alg.modifying.operations/alg.move/move.pass.cpp
+++ test/std/algorithms/alg.modifying.operations/alg.move/move.pass.cpp
@@ -53,7 +53,7 @@
OutIter r = std::move(InIter(ia), InIter(ia+N), OutIter(ib));
assert(base(r) == ib+N);
for (unsigned i = 0; i < N; ++i)
- assert(*ib[i] == i);
+ assert(*ib[i] == static_cast<int>(i));
}
#endif // _LIBCPP_HAS_NO_RVALUE_REFERENCES
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
