================
@@ -2497,7 +2501,9 @@ class Parser : public CodeCompletionHandler {
void ParseStructDeclaration(
ParsingDeclSpec &DS,
- llvm::function_ref<void(ParsingFieldDeclarator &)> FieldsCallback);
+ llvm::function_ref<void(ParsingFieldDeclarator &, Decl *&)>
----------------
delcypher wrote:
Why are we adding using `Decl*&` as a parameter? Would it make more sense as a
return value? All the uses I can see unconditionally write to the variable so
this isn't an `inout` parameter. It seems like its just an `out` parameter
which means it could be a return value instead.
https://github.com/llvm/llvm-project/pull/87596
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
