revane wrote:

Macros are tricky business and I understand why renaming is not allowed within 
macros. For the cases in the lit test, the renaming seems safe. Is this 
generally the case (i.e. those permitted by 
`clang::tidy::utils::rangeCanBeFixed()`)? What other test cases can we add? Or 
is this change just not safe? If so, how can we update the "InsideMacro" tests 
to actually fail even in the presence of a SourceManager.

https://github.com/llvm/llvm-project/pull/87792
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to