================
@@ -166,17 +166,20 @@ static Value *joinDistinctValues(QualType Type, Value 
&Val1,
   return JoinedVal;
 }
 
-// When widening does not change `Current`, return value will equal `&Prev`.
-static Value &widenDistinctValues(QualType Type, Value &Prev,
-                                  const Environment &PrevEnv, Value &Current,
-                                  Environment &CurrentEnv,
-                                  Environment::ValueModel &Model) {
+namespace {
+using WidenResult = Environment::ValueModel::WidenResult;
+}
+
+static WidenResult widenDistinctValues(QualType Type, Value &Prev,
----------------
martinboehme wrote:

```suggestion
static Environment::ValueModel::WidenResult widenDistinctValues(QualType Type, 
Value &Prev,
```

AFAICT, this is used exactly once. Maybe just spell it out?

https://github.com/llvm/llvm-project/pull/87233
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to