STL_MSFT added a comment. My changes to the ofstream.cons tests preserve the test coverage (as they already contain the machinery to create writable files).
Would you like it if I removed the "if (fs) { stuff }" blocks from the ifstream.cons tests entirely, and changed the comments to say things along the lines of "for basic_ifstream(const char *, ios_base::openmode) tests, we need writable files, so see BLAH"? https://reviews.llvm.org/D26814 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits