================
@@ -15,6 +15,7 @@
 #ifndef UNWIND_ASSEMBLY_H
 #define UNWIND_ASSEMBLY_H
 
+#ifndef __wasm__
----------------
EricWF wrote:

Again, this is not OK.

First, this file just defines macros, so even under WASM it should be safe to 
include.
If you're hitting the `#error` case in the `#else`, then add an `#elif 
__wasm__`.

While his style of code may not cause issues for you, because you don't use it. 
It makes things more complicated for every change that actually uses these 
files.



https://github.com/llvm/llvm-project/pull/79667
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to