================ @@ -0,0 +1,112 @@ +//===--- MathMissingParenthesesCheck.cpp - clang-tidy ---------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "MathMissingParenthesesCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::readability { + +void MathMissingParenthesesCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(binaryOperator(unless(hasParent(binaryOperator())), + unless(allOf(hasOperatorName("&&"), + hasOperatorName("||"))), + hasDescendant(binaryOperator())) + .bind("binOp"), + this); +} + +static int getPrecedence(const BinaryOperator *BinOp) { + if (!BinOp) + return 0; + switch (BinOp->getOpcode()) { + case BO_Mul: + case BO_Div: + case BO_Rem: + return 5; + case BO_Add: + case BO_Sub: + return 4; + case BO_And: + return 3; + case BO_Xor: + return 2; + case BO_Or: + return 1; + default: + return 0; + } +} +static bool addParantheses( + const BinaryOperator *BinOp, const BinaryOperator *ParentBinOp, + std::vector< + std::pair<clang::SourceRange, std::pair<const clang::BinaryOperator *, + const clang::BinaryOperator *>>> + &Insertions, + const clang::SourceManager &SM, const clang::LangOptions &LangOpts) { + bool NeedToDiagnose = false; + if (!BinOp) + return NeedToDiagnose; + + if (ParentBinOp != nullptr && + getPrecedence(BinOp) != getPrecedence(ParentBinOp)) { + NeedToDiagnose = true; + const clang::SourceLocation StartLoc = BinOp->getBeginLoc(); + clang::SourceLocation EndLoc = + clang::Lexer::getLocForEndOfToken(BinOp->getEndLoc(), 0, SM, LangOpts); + Insertions.push_back( + {clang::SourceRange(StartLoc, EndLoc), {BinOp, ParentBinOp}}); ---------------- 5chmidti wrote:
Instead of filling this vector, you could move emitting the diagnostic itself into this function by passing it the check itself like in https://github.com/llvm/llvm-project/blob/6aa53888a8e8a6e3f0bd279539703f4d4701b4e7/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp#L377-L379 Because whatever you push into the vector will be diagnosed. This would remove the need for the vector and the bool return type. https://github.com/llvm/llvm-project/pull/84481 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
