================ @@ -0,0 +1,342 @@ +//===--- MinMaxUseInitializerListCheck.cpp - clang-tidy -------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "MinMaxUseInitializerListCheck.h" +#include "../utils/ASTUtils.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Frontend/CompilerInstance.h" +#include "clang/Lex/Lexer.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::modernize { + +struct FindArgsResult { + const Expr *First; + const Expr *Last; + const Expr *Compare; + std::vector<const Expr *> Args; +}; + +static const FindArgsResult findArgs(const CallExpr *Call); +static std::vector<std::pair<int, int>> +getCommentRanges(const std::string &source); +static bool +isPositionInComment(int position, + const std::vector<std::pair<int, int>> &commentRanges); +static void +removeCharacterFromSource(std::string &FunctionCallSource, + const std::vector<std::pair<int, int>> &CommentRanges, + char Character, const CallExpr *InnerCall, + std::vector<FixItHint> &Result, bool ReverseSearch); +static SourceLocation +getLocForEndOfToken(const Expr *expr, const MatchFinder::MatchResult &Match); +static const std::vector<FixItHint> +generateReplacement(const MatchFinder::MatchResult &Match, + const CallExpr *TopCall, const FindArgsResult &Result); ---------------- 5chmidti wrote:
Don't return values (not references) by const, same goes for the definition of these functions. You comment handling functions are also not needed, see comments on `generateReplacement` https://github.com/llvm/llvm-project/pull/85572 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
