https://github.com/NagyDonat approved this pull request.
Seems to be a nice improvement, I'm happy to see this boilerplate removal and reducing the code length by 120 lines is impressive. (Disclaimer: I didn't do a line-by-line review of the changes, but I hope that testing etc. validates that the change is indeed NFC.) However, please add "part 2" to the title line of the commit, because it is/was confusing to have two commits with identical titles that are very close to each other. In general, the title line should be an identifier that's reasonable unique for the human readers (while the commit hash is the machine-readable exact identifier). It's completely fine if a commit title happens to be identical to a 10-year-old commit, but please try to avoid confusion between commits that might "appear" in the same context. https://github.com/llvm/llvm-project/pull/82228 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
