https://github.com/NagyDonat commented:

The code LGTM with some minor remarks, but I'm not familiar with these MS 
functions.

I'm not sure whether these "builtin by Microsoft" functions are in scope for 
"our" BuiltinFunctionChecker which previously only checked functions that are 
recognized as `Builtin::BI__something` by Clang. (However, I can believe that 
there is no better place for them and I don't think that they would cause 
problems here.)

https://github.com/llvm/llvm-project/pull/80456
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to