llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-analysis Author: Haojian Wu (hokein) <details> <summary>Changes</summary> I called this function when investigating the issue (https://github.com/llvm/llvm-project/issues/78131), and I was surprised to see the definition is commented out. I think it makes sense to provide the definition even though the implementation is not stable. --- Full diff: https://github.com/llvm/llvm-project/pull/80277.diff 2 Files Affected: - (modified) clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h (+1) - (modified) clang/lib/Analysis/ThreadSafetyCommon.cpp (-2) ``````````diff diff --git a/clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h b/clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h index 13e37ac2b56b6..4edd3374dd61b 100644 --- a/clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h +++ b/clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h @@ -528,6 +528,7 @@ class SExprBuilder { }; // Dump an SCFG to llvm::errs(). +// The implementation is not stable, and used for debugging only. void printSCFG(CFGWalker &Walker); } // namespace threadSafety diff --git a/clang/lib/Analysis/ThreadSafetyCommon.cpp b/clang/lib/Analysis/ThreadSafetyCommon.cpp index 2fe0f85897c3b..fc5b7d3b6f197 100644 --- a/clang/lib/Analysis/ThreadSafetyCommon.cpp +++ b/clang/lib/Analysis/ThreadSafetyCommon.cpp @@ -995,7 +995,6 @@ void SExprBuilder::exitCFG(const CFGBlock *Last) { IncompleteArgs.clear(); } -/* namespace { class TILPrinter : @@ -1016,4 +1015,3 @@ void printSCFG(CFGWalker &Walker) { } // namespace threadSafety } // namespace clang -*/ `````````` </details> https://github.com/llvm/llvm-project/pull/80277 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
