ilovepi wrote:

while its kind of nice to see the complete patch, it looks to me like each of 
these changes is independent, and should be stacked rather than commited in 
bulk. Many of us have had good experience with `spr`, so I'd suggest maybe 
abandoning this PR and re-uploading a stack that can have each part reviewed 
independently. This will make our review much easier, and the independent 
changes can land on their own. Plus it will make adding reviewers much easier.

https://github.com/llvm/llvm-project/pull/80104
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to