Author: dergachev Date: Mon Oct 31 16:11:20 2016 New Revision: 285640 URL: http://llvm.org/viewvc/llvm-project?rev=285640&view=rev Log: [analyzer] Allow undefined values in performTrivialCopy.
Reading from a garbage pointer should be modeled as garbage, and performTrivialCopy should be able to deal with any SVal input. Patch by Ilya Palachev! Differential Revision: https://reviews.llvm.org/D25727 Added: cfe/trunk/test/Analysis/uninit-vals.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp?rev=285640&r1=285639&r2=285640&view=diff ============================================================================== --- cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp (original) +++ cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Mon Oct 31 16:11:20 2016 @@ -65,7 +65,7 @@ void ExprEngine::performTrivialCopy(Node if (Optional<Loc> L = V.getAs<Loc>()) V = Pred->getState()->getSVal(*L); else - assert(V.isUnknown()); + assert(V.isUnknownOrUndef()); const Expr *CallExpr = Call.getOriginExpr(); evalBind(Dst, CallExpr, Pred, ThisVal, V, true); Added: cfe/trunk/test/Analysis/uninit-vals.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/uninit-vals.cpp?rev=285640&view=auto ============================================================================== --- cfe/trunk/test/Analysis/uninit-vals.cpp (added) +++ cfe/trunk/test/Analysis/uninit-vals.cpp Mon Oct 31 16:11:20 2016 @@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -analyze -analyzer-checker=core.builtin -verify -DCHECK_FOR_CRASH %s +// RUN: %clang_cc1 -analyze -analyzer-checker=core -verify %s + +#ifdef CHECK_FOR_CRASH +// expected-no-diagnostics +#endif + +namespace PerformTrivialCopyForUndefs { +struct A { + int x; +}; + +struct B { + A a; +}; + +struct C { + B b; +}; + +void foo() { + C c1; + C *c2; +#ifdef CHECK_FOR_CRASH + // If the value of variable is not defined and checkers that check undefined + // values are not enabled, performTrivialCopy should be able to handle the + // case with undefined values, too. + c1.b.a = c2->b.a; +#else + c1.b.a = c2->b.a; // expected-warning{{Function call argument is an uninitialized value}} +#endif +} +} + _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
